Skip to content

Partial version of Unitful.uconvert()#26

Open
abhro wants to merge 3 commits intosostock:mainfrom
abhro:partial-uconvert
Open

Partial version of Unitful.uconvert()#26
abhro wants to merge 3 commits intosostock:mainfrom
abhro:partial-uconvert

Conversation

@abhro
Copy link
Copy Markdown
Contributor

@abhro abhro commented Nov 21, 2025

Solves #21

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (639a24c) to head (d5ddf5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           56        57    +1     
=========================================
+ Hits            56        57    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abhro abhro marked this pull request as ready for review December 19, 2025 04:01
Copy link
Copy Markdown
Owner

@sostock sostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Since the convenient shortcut u(e) instead of uconvert(u, e) is available (as used in the original issue), I think it could be mentioned in the docstring and should be tested as well. That’s why I propose the following changes.

@abhro
Copy link
Copy Markdown
Contributor Author

abhro commented Jan 25, 2026

Thanks for your contribution. Since the convenient shortcut u(e) instead of uconvert(u, e) is available (as used in the original issue), I think it could be mentioned in the docstring and should be tested as well. That’s why I propose the following changes.

Sounds good! Committing

Use units themselves as callables to do `uconvert`

Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants