Skip to content

Conversation

@brendan-kellam
Copy link
Contributor

Fixes a issue where connections would always sync on startup, regardless if they had changed or not. Issue was we were using JSON.stringify for our comparisons, which does not guarantee any orderings of properties. Switched to using fast-deep-euqal.

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bkellam/fix_connection_sync_on_startup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@brendan-kellam brendan-kellam merged commit 06c84f0 into main Nov 12, 2025
9 checks passed
@brendan-kellam brendan-kellam deleted the bkellam/fix_connection_sync_on_startup branch November 12, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants