Open
Conversation
chebyte
commented
Jul 8, 2015
chebyte
commented
- Adds each_with_concurrency method
- Updates Readme
* Adds each_with_concurrency method * Updates Readme
|
@scalp42 @chebyte Sorry for waking this up, but I'm doing some research on how to use Redis with a distributed lock for queues and I was wondering, how does this PR handle removing from the backup queue? In a perfect world order wouldn't matter and if you process 5 items, then 5 will be popped. But in scenarios where exceptions are thrown you might pop the wrong items. |
|
I see that this commit is missing https://github.com/soveran/ost/pull/8/files#diff-e007f35caa5af71683eeaa305ba27a2cR38 that would make this actually work. But then you'd remove specific items instead of popping the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.