API-9331 additional fixes #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While integrating this fix with our projects, this regression popped up. I've added the same tests to this project. The bug was very obvious once I saw it: we need to pop the block group from the current level into the expressions for the next level up. I accidentally copied the bottom expressions all the way up. Shocked tests passed with this, honestly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating this fix with our projects, this regression popped up. I've added the same tests to this project.
The bug was very obvious once I saw it: we need to pop the block group from the current level into the expressions for the next level up. I accidentally copied the bottom expressions all the way up. Shocked tests passed with this, honestly.