fix(docs): update sphinxemoji to fix Python 3.12+ compatibility#2115
Open
thanhlim wants to merge 1 commit intospec-first:mainfrom
Open
fix(docs): update sphinxemoji to fix Python 3.12+ compatibility#2115thanhlim wants to merge 1 commit intospec-first:mainfrom
thanhlim wants to merge 1 commit intospec-first:mainfrom
Conversation
Author
|
Opened against wrong base. Recreating against upstream main directly. |
sphinxemoji 0.2.0 uses pkg_resources which was removed in Python 3.12. Update to 0.3.1 which uses importlib.resources instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
ec9f82b to
fa68d21
Compare
Contributor
|
I cloned your repo, checked out your branch and ran Here's the Py313 error: Do you see anything similar when you run tox? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sphinxemojifrom0.2.0to0.3.1inpyproject.tomlsphinxemoji 0.2.0usespkg_resourceswhich was removed in Python 3.12, causing doc builds to fail0.3.1usesimportlib.resourcesinsteadSupersedes #2111 (which included unrelated changes).
Test plan
🤖 Generated with Claude Code