Skip to content

Fixed docs examples URLs redirecting to the examples repository#1668

Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom
armanossiloko:docfix/commandapp_examples_links
Oct 18, 2024
Merged

Fixed docs examples URLs redirecting to the examples repository#1668
patriksvensson merged 1 commit intospectreconsole:mainfrom
armanossiloko:docfix/commandapp_examples_links

Conversation

@armanossiloko
Copy link

@armanossiloko armanossiloko commented Oct 17, 2024

resolves #1667

  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

As per #1667 - the docs examples URLs currently lead to a Github HTTP 404 as they refer to a directory named examples/ which I suppose recently had been moved to the examples repository and it bothered me every time I go to the docs, so I just had to do this PR.


Please upvote 👍 this pull request if you are interested in it.

@armanossiloko
Copy link
Author

@armanossiloko please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patriksvensson patriksvensson merged commit a32dc80 into spectreconsole:main Oct 18, 2024
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@armanossiloko armanossiloko deleted the docfix/commandapp_examples_links branch October 18, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs - examples URLs link to 404

2 participants

Comments