Option to exclude vertical padding for live progress renderer#2100
Open
james-newell-forge wants to merge 1 commit intospectreconsole:mainfrom
Open
Option to exclude vertical padding for live progress renderer#2100james-newell-forge wants to merge 1 commit intospectreconsole:mainfrom
james-newell-forge wants to merge 1 commit intospectreconsole:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="ForgeGlobal" |
patriksvensson
requested changes
Apr 25, 2026
| /// <param name="progress">The <see cref="Progress"/> instance.</param> | ||
| /// <param name="enabled">Whether or not to exclude the vertical padding.</param> | ||
| /// <returns>The same instance so that multiple calls can be chained.</returns> | ||
| public static Progress ExcludeVerticalPadding(this Progress progress, bool enabled) |
Contributor
There was a problem hiding this comment.
We should add two new methods that call this one to make the API consistent:
ExcludeVerticalPadding(this Progress progress)IncludeVerticalPadding(this Progress progress)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1726
No AI was used in commit
Changes
Currently, a live progress widget forces you to have a 1-top, 1-bottom vertical padding and there is no option to change this. This commit adds a new option to
Progress.cscalledExcludeVerticalPaddingthat when set excludes the Padder added inDefaultProgressRenderer.cs(default false to keep existing behavior).