js domain: Remove extra brackets from function arguments and errors#13569
Merged
AA-Turner merged 4 commits intosphinx-doc:masterfrom Nov 30, 2025
Merged
js domain: Remove extra brackets from function arguments and errors#13569AA-Turner merged 4 commits intosphinx-doc:masterfrom
AA-Turner merged 4 commits intosphinx-doc:masterfrom
Conversation
SilverRainZ
force-pushed
the
js-domain-parens
branch
4 times, most recently
from
0bc9311 to
8748a5d
Compare
Member
|
Can you add tests? |
AA-Turner
added
the
awaiting:response
Contributor
Author
|
I have added a test |
Contributor
Author
|
@AA-Turner Excuse me, may I ask what test is still missing? I am not familiar with Sphinx's testing. |
SilverRainZ
force-pushed
the
js-domain-parens
branch
from
841b705 to
c35f966
Compare
Contributor
Author
|
I have rebased the branch to master and updated the test. |
AA-Turner
added
domains:js
and removed
awaiting:response
# Conflicts: # CHANGES.rst
AA-Turner
approved these changes
Nov 30, 2025
AA-Turner
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #13217.