Support images with non-base64 data URIs#14006
Merged
AA-Turner merged 7 commits intosphinx-doc:masterfrom Nov 25, 2025
Merged
Conversation
The previous code that manually parsed data URIs had a bug: Exception is raised when parsing non-base64 encoded data URIs. Using urllib completely avoids these problems and simplifies the project.
# Conflicts: # CHANGES.rst
urllib.request.DataHandler in parse_data_uri
AA-Turner
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The previous code that manually parsed data URIs had a bug: an Exception is raised when parsing non-base64 encoded data URIs. Using urllib completely avoids these problems and
simplifies the project.
Reproduce
index.rst:
Run
make dummywe got:References