FIX: Social media twitter card tags#101
Merged
Daltz333 merged 1 commit intosphinx-doc:mainfrom Apr 13, 2023
Merged
Conversation
Contributor
Author
|
ping - this is a bug, the cards won't really work on twitter until it is merged+released. |
Contributor
Author
|
pinging @TheTripleV and @Daltz333 again. can somebody please review/merge/release? I would be happy to do this myself but I don't have the permissions on this repo/pypi. |
Daltz333
approved these changes
Apr 13, 2023
Contributor
Author
|
Thanks <3 - I know you all likely have a million other things going on so I appreciate you taking the time to review/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught a bug that we weren't testing for. The
summary_large_imagetag wasn't being properly inserted. This fixes that bug, and also adds a test for it.