make matplotlib optional#104
Merged
Daltz333 merged 4 commits intosphinx-doc:mainfrom Jul 7, 2023
TheTripleV:main
Merged
Conversation
Collaborator
|
Will this break any existing users (aka is it opt-out instead of opt-in)? |
Contributor
|
Well the issue from #100 was asking for it to be opt-in, since it was added recently, right? |
Collaborator
Author
|
If matplotlib is installed, it's opt out. If matplotlib isn't installed, it doesn't run. So it should keep existing behavior. |
Collaborator
|
So this should only break CI environments for users. That still is pretty bad, but I'm not sure there is a better solution. |
Collaborator
Author
|
No it shouldn't break ci for anyone. If matplotlib isn't installed it just turns off image generation |
Collaborator
|
I wish there was a behavior where we automatically instead matplotlib and the user can explicitly choose not to instead it, instead of the opposite. |
Collaborator
Author
|
I don't think that's possible |
Daltz333
approved these changes
Jul 7, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #100