Merged
Conversation
Remove pin to Sphinx <7.3 since Sphinx 7.4 fixed issue Test Python 3.8 and 3.9 only on supported Sphinx Versions
Contributor
|
Perhaps, when adding support for Sphinx 8, it's also a good time to drop support for Sphinx 5? |
TheTripleV
approved these changes
Aug 1, 2024
Collaborator
Sphinx 5 only came out 2 years ago (2 years, 1 months and 15 days) so it feels weird to drop it. I didn't realize Sphinx was bumping the major version more than once a year now. I'm fine not actually supporting it but its nice to have in CI as a sanity check until it breaks enough that I don't care (or its too much effort to keep in). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove pin to Sphinx <7.3 since Sphinx 7.4 fixed issue
Test Python 3.8 and 3.9 only on supported Sphinx Versions