You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is a minimal patch to avoid breaking when a user has an SVG image. Ideally we would catch this and raise a warning in Sphinx, but I wanted to show the minimal patch to avoid the bug if you wanna make a patch release. I likely don't have time to do a proper implementation w/ a warning and such (am expecting a baby any day now)
Just signal-boosting this. I'd recommend a patch release just after. As-is, anybody that was using an .svg file for their html_logo will have a broken Sphinx build when they upgrade to the latest sphinxext-opengraph.
Just signal-boosting this. I'd recommend a patch release just after. As-is, anybody that was using an .svg file for their html_logo will have a broken Sphinx build when they upgrade to the latest sphinxext-opengraph.
OK the latest push adds a test that fails on main but passes with this change. I couldn't find a way to catch the warning messages in Sphinx but at least this will fail if we regress the check for SVG. I also added a check to make sure the path exists for good measure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a minimal patch to avoid breaking when a user has an SVG image. Ideally we would catch this and raise a warning in Sphinx, but I wanted to show the minimal patch to avoid the bug if you wanna make a patch release. I likely don't have time to do a proper implementation w/ a warning and such (am expecting a baby any day now)