This repository was archived by the owner on Mar 31, 2022. It is now read-only.
Validation of docker repository names#275
Merged
mattnworb merged 4 commits intospotify:masterfrom Mar 12, 2019
Merged
Conversation
An invalid name will now cause an early build failure with a clear message in the build log, rather than the incomprehensible “broken pipe” error at docker build time.
|
this is the cause of #308 which seems like a pretty serious regression. |
Contributor
Author
|
Indeed - fixed, I'll do a PR now. |
Contributor
Author
|
ah... it's been fixed already, the PR is pending: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an early validation of repo names specified in the pom.
An invalid name will now cause an early build failure with a clear message in the build log, rather than the incomprehensible “broken pipe” error at docker build time.