Skip to content
This repository was archived by the owner on Mar 31, 2022. It is now read-only.

Update docker-client version to 8.14.5#280

Merged
davidxia merged 1 commit intospotify:masterfrom
lasselindqvist:issue-278
Apr 30, 2019
Merged

Update docker-client version to 8.14.5#280
davidxia merged 1 commit intospotify:masterfrom
lasselindqvist:issue-278

Conversation

@lasselindqvist
Copy link
Copy Markdown
Contributor

Fixes #278

This update fixes issue described here spotify/docker-client#875 about supporting Windows named pipes.

This update fixes issue described here spotify/docker-client#875 about supporting Windows named pipes.
@lasselindqvist
Copy link
Copy Markdown
Contributor Author

@mattnworb, @davidxia, any chance this could be looked at?

Copy link
Copy Markdown
Contributor

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lasselindqvist sorry for the delay. This looks good to me. I'm going to close and reopen to try to get the stuck travis build to work.

@davidxia davidxia closed this Apr 30, 2019
@davidxia davidxia reopened this Apr 30, 2019
@davidxia davidxia merged commit 33bd6f9 into spotify:master Apr 30, 2019
@lasselindqvist
Copy link
Copy Markdown
Contributor Author

Is it possible to push the release 1.4.11 to Maven Central? I can built the release myself, but it would be nicer to have it available there.

@davidxia
Copy link
Copy Markdown
Contributor

davidxia commented May 8, 2019

@lasselindqvist sorry for the delay. I just released 1.4.11 to Maven Central.

@lasselindqvist
Copy link
Copy Markdown
Contributor Author

@davidxia
Copy link
Copy Markdown
Contributor

davidxia commented May 15, 2019

@mattnworb do you remember how we release this? I can get the 1.4.11-SNAPSHOT uploaded to oss.sonatype.org but not 1.4.11. I'm running mvn clean -P release -DskipTests -Darguments=-DskipTests -Dgpg.keyname=DC90312C release:prepare release:perform --batch-mode

This only creates a maven-release-plugin] prepare for next development iteration commit but not the maven-release-plugin] prepare release v1.4.11 that should come before.

@davidxia
Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docker-client 8.14.5 or newer

2 participants