Master by ymugoder · Pull Request #103 · spotinst/spotinst-examples

ymugoder · 2024-06-21T06:32:37Z

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket

Include a link to your Jira Ticket
Example: JIRAISS-1234

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

I have filled relevant self assessment (NodeJS, Frontend, Backend)
I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have validated all the requirements in the Jira task were answered
I have all neccessary approvals for the design/mini design of this task
I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.3 to 2.0.6. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.0.3...2.0.6) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Added 2 permissions for AccessEKS. DescribeNodegroup and ListNodegroups These 2 allow the new Spot Console Integration to auto-create VNGs for each EKS Cluster

…CLI (#89) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.4. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.4) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…r-and-bucket template updated (#96)

…ates (#97)

* SF-8332 - Add support for onboarding all subscriptions in a tenant. A… (#1) * SF-8332 - Add support for onboarding all subscriptions in a tenant. Add support for onboarding the Cost Intelligence product. * PR comments. * SF-9925 - Added error handling for individual subscriptions. Updated (#2) * SF-9925 - Added error handling for individual subscriptions. Updated logging. * Added comments. Added failed subscriptions to output. * logging tweaks * renamed extension install method

* Updating custom role definition source for core products. * Clean up comments. * More cleanup.

We do required the following to get allow STS iam:PassRole

…re resource creation (#102)

Utilities/AzureOnboardingCLI/azure-automatic-role-assignment.py

+
+
+def log(message, log_level=LogLevel.INFO):
+    print(f"{datetime.now().strftime('%H:%M:%S.%f')[:-3]} [{log_level}] {message}")


* add ListAccountAliases to EKS StackSet * remove buggy output code * add gc onboarder script * fix format * format fix * fix format * fix formatting * fix wording * fix url * fix content * fix content * update readme * fix examples * update read-only default to false * download role once * remove spot_account_id * grammar fixes * add csv list option for subscription onboarding * add file based onboarding * remove unused import * clean up comments

…r Spot Security product. (#105)

* [src] SF-21801: Add Eco terraform setup scripts. * [src] SF-21801: Add Eco onboarding setup scripts. * [src] SF-21801: Remove unused policies for Eco.

Utilities/AzureSetup/CSP/eco_azure_full_access.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/CSP/eco_azure_readonly.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/EA/eco_azure_full_access.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/EA/eco_azure_readonly.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/MCA/eco_azure_full_access.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/MCA/eco_azure_readonly.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/PAYG/eco_azure_full_access.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


Utilities/AzureSetup/PAYG/eco_azure_readonly.py

+
+
+print(f"App ID: {app_id}")
+print(f"Secret Key: {secret_key}")


github-advanced-security · 2025-05-28T14:12:01Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

…tion (#107)

dependabot bot and others added 10 commits October 3, 2023 06:21

Update Spot-AWS-Restricted-EKS.json (#91)

1e0b14f

Added 2 permissions for AccessEKS. DescribeNodegroup and ListNodegroups These 2 allow the new Spot Console Integration to auto-create VNGs for each EKS Cluster

Update SpotFinOps IAM Read Only role policy template (#94)

5e5dca5

spot-iam-finopsrole-stack-restricted-read-only-limited-assume-with-cu…

c0ff864

…r-and-bucket template updated (#96)

[src] SF-4348: Add external ID to read only role, deprecate old templ…

bb857f5

…ates (#97)

Update custom role definition source for core products (#100)

9e08415

* Updating custom role definition source for core products. * Clean up comments. * More cleanup.

Update Spot-AWS-Restricted-Full-Permissions.json (#101)

b293eac

We do required the following to get allow STS iam:PassRole

SF-10715 - Updating Azure onboarding script to allow for skipping azu…

7d4f7cd

…re resource creation (#102)

github-advanced-security bot found potential problems Jun 21, 2024

View reviewed changes

wesctl and others added 3 commits July 18, 2024 10:59

SF-14969 - Updating Azure onboarding script to include permissions fo…

ec7fbd1

…r Spot Security product. (#105)

[src] SF-21801: Add Eco setup scripts. (#106)

22aec43

* [src] SF-21801: Add Eco terraform setup scripts. * [src] SF-21801: Add Eco onboarding setup scripts. * [src] SF-21801: Remove unused policies for Eco.

github-advanced-security bot found potential problems May 28, 2025

View reviewed changes

[src] SF-23264: Update Eco Azure setup scripts and add postman collec…

0a103eb

…tion (#107)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Master#103

Master#103
ymugoder wants to merge 14 commits intoazure-aks-ocean-examplefrom
master

ymugoder commented Jun 21, 2024

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

github-advanced-security bot commented May 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants



		def log(message, log_level=LogLevel.INFO):
		print(f"{datetime.now().strftime('%H:%M:%S.%f')[:-3]} [{log_level}] {message}")



		print(f"App ID: {app_id}")
		print(f"Secret Key: {secret_key}")

Comments

Conversation

ymugoder commented Jun 21, 2024

Jira Ticket

Demo

Checklist:

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

github-advanced-security bot commented May 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants