Skip to content
This repository was archived by the owner on Mar 3, 2020. It is now read-only.

Add active template for the customer model design#3

Open
dkubb wants to merge 1 commit intospree-contrib:masterfrom
MountainRoseHerbs:feature/master/add-customer-model
Open

Add active template for the customer model design#3
dkubb wants to merge 1 commit intospree-contrib:masterfrom
MountainRoseHerbs:feature/master/add-customer-model

Conversation

@dkubb
Copy link

@dkubb dkubb commented Jul 7, 2015

This branch adds a proposal for adding the Spree::Customer object to spree.

@dkubb
Copy link
Author

dkubb commented Jul 7, 2015

@JDutil I've created this proposal for Spree::Customer as you requested (on twitter).

@JDutil
Copy link
Member

JDutil commented Jul 9, 2015

I think the reasoning behind this makes sense to bridge the gap between online/offline orders, but I think it's going to be a real tough sell. The drawback of changing so many interrelated parts is quite large, and would necessitate a new major version & deprecating much of the current public api.

@dkubb
Copy link
Author

dkubb commented Jul 9, 2015

@JDutil I need this for work, so I'm probably going to begin implementation on it now. If the community doesn't want to take it up, then I'll probably have to fork -- something we've tried really hard not to do.

However, on the flip side I'm going to be touching lots of old code and old specs, and this'll give me a chance to clean them up. That alone might be enough benefit to accept the change.

@dpritchett
Copy link

"Make things integrate easily with tomorrow's SPA data access trends" seems
like a pretty crucial piece of Spree's longterm growth strategy, no? This
seems like it's at least as big as the Spree 3.0 port to Bootstrap.

Possible solutions here include Dan making his own API namespace that
solves his needs without breaking the others and then maybe moving Spree to
prefer it longterm.

When's the next major Spree release out anyway? I can't find the old
Trello roadmap anymore to use as a crystal ball.
https://trello.com/b/PQsUfCL0/spree-roadmap

On Thu, Jul 9, 2015 at 1:01 PM, Dan Kubb notifications@github.com wrote:

@JDutil https://github.com/JDutil I need this for work, so I'm probably
going to begin implementation on it now. If the community doesn't want to
take it up, then I'll probably have to fork -- something we've tried really
hard not to do.

However, on the flip side I'm going to be touching lots of old code and
old specs, and this'll give me a chance to clean them up. That alone might
be enough benefit to accept the change.


Reply to this email directly or view it on GitHub
#3 (comment).

@JDutil
Copy link
Member

JDutil commented Jul 9, 2015

The next major Spree version would be whenever the work for it is done we don't set timelines so I don't know when that will be. The only feature I'd currently expect for it is API v2, and there was some refactoring being done to hopefully finally address the database deadlock issues.

@BenMorganIO
Copy link
Contributor

I'm currently working on setting up a JSON API to the spec right now. I'd expect lots of initial work coming in before the end of July.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants