Use newCachedTreadPool() instead of newSingleThreadExecutor() in InetUtils#1365
Merged
OlgaMaciaszek merged 3 commits intospring-cloud:4.1.xfrom Sep 25, 2024
Merged
Use newCachedTreadPool() instead of newSingleThreadExecutor() in InetUtils#1365OlgaMaciaszek merged 3 commits intospring-cloud:4.1.xfrom
OlgaMaciaszek merged 3 commits intospring-cloud:4.1.xfrom
Conversation
Collaborator
|
Fixes gh-1364. |
OlgaMaciaszek
requested changes
Aug 23, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hi @stsypanov. Thanks for adding the PR. However, could you please submit the change against the 4.1.x branch instead? Also, please add your full name and last name with the @author tag to the class Javadoc and update the date in the license comment to 2012-2024
added 2 commits
September 17, 2024 09:41
Contributor
Author
|
@OlgaMaciaszek done! I've also removed TODO comment as the executor is shut down in |
stsypanov
changed the title
OlgaMaciaszek
approved these changes
Sep 25, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks @stsypanov. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1364