Make SQL Without Profile Adaptive#2200
Merged
ryanjbaxter merged 1 commit intospring-cloud:3.1.xfrom Dec 15, 2022
Merged
Conversation
cba42fd to
1fa7cea
Compare
Codecov ReportBase: 77.15% // Head: 77.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 3.1.x #2200 +/- ##
============================================
+ Coverage 77.15% 77.51% +0.35%
- Complexity 1455 1479 +24
============================================
Files 183 186 +3
Lines 5376 5456 +80
Branches 705 709 +4
============================================
+ Hits 4148 4229 +81
+ Misses 954 946 -8
- Partials 274 281 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ryanjbaxter
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new SQL Without Profile feature breaks existing projects like #2185. Here provides another solution that don't need to introduce a new flag. If users changed both
sqlandsqlWithoutProfileproperty or leave them both unchanged, then the new feature will be enabled. Otherwise, the config will be considered as incomplete and fallback to previous behavior. This will keep it compatible with previous projects.