Skip to content

Comments

Make SQL Without Profile Adaptive#2200

Merged
ryanjbaxter merged 1 commit intospring-cloud:3.1.xfrom
woshikid:adaptive-sql-without-profile
Dec 15, 2022
Merged

Make SQL Without Profile Adaptive#2200
ryanjbaxter merged 1 commit intospring-cloud:3.1.xfrom
woshikid:adaptive-sql-without-profile

Conversation

@woshikid
Copy link
Contributor

The new SQL Without Profile feature breaks existing projects like #2185. Here provides another solution that don't need to introduce a new flag. If users changed both sql and sqlWithoutProfile property or leave them both unchanged, then the new feature will be enabled. Otherwise, the config will be considered as incomplete and fallback to previous behavior. This will keep it compatible with previous projects.

@woshikid woshikid force-pushed the adaptive-sql-without-profile branch from cba42fd to 1fa7cea Compare December 15, 2022 10:41
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 77.15% // Head: 77.51% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (1fa7cea) compared to base (bc8227c).
Patch coverage: 88.70% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##              3.1.x    #2200      +/-   ##
============================================
+ Coverage     77.15%   77.51%   +0.35%     
- Complexity     1455     1479      +24     
============================================
  Files           183      186       +3     
  Lines          5376     5456      +80     
  Branches        705      709       +4     
============================================
+ Hits           4148     4229      +81     
+ Misses          954      946       -8     
- Partials        274      281       +7     
Impacted Files Coverage Δ
...er/environment/CompositeEnvironmentRepository.java 86.95% <ø> (ø)
...nfig/server/environment/EnvironmentController.java 91.95% <ø> (ø)
.../server/environment/JGitEnvironmentProperties.java 90.00% <ø> (-3.34%) ⬇️
...nvironment/AbstractVaultEnvironmentRepository.java 83.33% <50.00%> (-4.67%) ⬇️
...fig/server/ssh/PropertyBasedSshSessionFactory.java 80.00% <79.68%> (-3.88%) ⬇️
...ment/SearchPathCompositeEnvironmentRepository.java 92.85% <85.71%> (+3.96%) ⬆️
.../server/environment/JdbcEnvironmentRepository.java 78.12% <86.36%> (+7.75%) ⬆️
...ork/cloud/config/monitor/PropertyPathEndpoint.java 88.57% <100.00%> (-0.07%) ⬇️
...nfigServerBootstrapOverridesAutoConfiguration.java 100.00% <100.00%> (ø)
...onment/AwsParameterStoreEnvironmentRepository.java 100.00% <100.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanjbaxter ryanjbaxter added this to the 3.1.6 milestone Dec 15, 2022
@ryanjbaxter ryanjbaxter merged commit 52b1909 into spring-cloud:3.1.x Dec 15, 2022
@woshikid woshikid deleted the adaptive-sql-without-profile branch December 16, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants