fix: allow negative value for jgit environment to disable refresh#2393
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Mar 18, 2024
Merged
fix: allow negative value for jgit environment to disable refresh#2393ryanjbaxter merged 1 commit intospring-cloud:mainfrom
ryanjbaxter merged 1 commit intospring-cloud:mainfrom
Conversation
Modify `JGitEnvironmentRepository` to return `false` on `shouldPull` method when `refreshRate` is a negative value Fixes spring-cloudgh-2256
spencergibb
approved these changes
Mar 15, 2024
Contributor
Contributor
Author
|
Both resolve my issue in different ways as long as #2394 works but I need to do some testing. Obeying timeouts would be a better solution for me. Skipping refresh would be a more manual solution since we'd have to update the value when our Git server was restored. It seems like there is still value in this PR given that an issue was created by other users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
JGitEnvironmentRepositoryto returnfalseonshouldPullmethod whenrefreshRateis a negative valueFixes gh-2256