skip controllers#1943
Merged
ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom Jul 15, 2025
wind57:skip_controllers
Merged
skip controllers#1943ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom wind57:skip_controllers
ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom
wind57:skip_controllers
Conversation
Signed-off-by: wind57 <eugen.rabii@gmail.com>
wind57
commented
Jul 2, 2025
| shell: bash | ||
| run: | | ||
| ./mvnw -q exec:exec -Dexec.classpathScope="test" -Dexec.executable="echo" -Dexec.args="%classpath" | tr : "\n" > /tmp/deps.txt | ||
| ./mvnw -q exec:exec -Dexec.classpathScope="test" -Dexec.executable="echo" -Dexec.args="%classpath" | tr : "\n" | grep -v spring-cloud-kubernetes-controllers > /tmp/deps.txt |
Contributor
Author
There was a problem hiding this comment.
we are already building and running the tests in the controllers project in the pre-test-actions/action.yaml:
- name: build controllers project
uses: ./.github/workflows/composites/build-controllers-project
where we run:
run: |
cd spring-cloud-kubernetes-controllers
.././mvnw -DCURRENT_INSTANCE=${CURRENT_INDEX} -T 1C -U clean install
cd ..
thus, we run the tests in the spring-cloud-kubernetes-controllers project already.
Until this fix, we were running them again. No need to do that twice
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Contributor
Author
|
@ryanjbaxter one more improvement that I noticed we can do. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.