Adds Discovery Server and Discovery Client#886
Merged
ryanjbaxter merged 11 commits intospring-cloud:mainfrom Oct 15, 2021
Merged
Adds Discovery Server and Discovery Client#886ryanjbaxter merged 11 commits intospring-cloud:mainfrom
ryanjbaxter merged 11 commits intospring-cloud:mainfrom
Conversation
added 9 commits
July 30, 2021 09:29
spencergibb
reviewed
Oct 14, 2021
| <plugins> | ||
| <plugin> | ||
| <groupId>com.spotify</groupId> | ||
| <artifactId>dockerfile-maven-plugin</artifactId> |
Member
There was a problem hiding this comment.
Curious if there's a reason we aren't using the boot built-in stuff?
Contributor
Author
There was a problem hiding this comment.
I thought it only built the image, I didn't know there was functionality to push the image to a registry. I Googled, but didn't see anything.
spencergibb
reviewed
Oct 14, 2021
...main/java/org/springframewok/cloud/kubernetes/discoveryserver/DiscoveryServerController.java
Outdated
Show resolved
Hide resolved
spencergibb
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.