Treat invalid pattern as bad request in EnvironmentEndpoint#49888
Closed
akshitk20 wants to merge 1 commit intospring-projects:mainfrom
Closed
Treat invalid pattern as bad request in EnvironmentEndpoint#49888akshitk20 wants to merge 1 commit intospring-projects:mainfrom
akshitk20 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Wrap PatternSyntaxException in InvalidEndpointRequestException when an invalid regex pattern is provided to the env actuator endpoint, ensuring a proper 400 Bad Request response. Closes spring-projectsgh-49884 Signed-off-by: Akshit Khatri <akshit.khatri@sap.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@akshitk20 please refrain from opening a PR for an issue that is still |
snicoll
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49884
Summary
EnvironmentEndpointpasses the user-suppliedpatterndirectly toPattern.compile()when filtering property names. An invalid regex (e.g.,GET /actuator/env?pattern=[)raises a
PatternSyntaxExceptionwhich is not translated into the actuator's standard bad-request path.This PR wraps
PatternSyntaxExceptionin anInvalidEndpointRequestException, ensuring a proper 400 Bad Request response. This follows the same pattern used inMetricsEndpoint.parseTag()for handling invalid user input.Changes
getPatternPredicate()method that catchesPatternSyntaxExceptionand throwsInvalidEndpointRequestExceptionInvalidEndpointRequestException