NimbusJwtDecoder silently accepts unknown values for spring.security.oauth2.resourceserver.jwt.jws-algorithms#50118
Open
vinhhieu21 wants to merge 2 commits intospring-projects:3.5.xfrom
Open
Conversation
Signed-off-by: Hieu Bui Vinh <buivinhhieu217@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
See spring-projectsgh-50116 Signed-off-by: Hieu Bui Vinh <buivinhhieu217@gmail.com>
Member
|
When reviewing this, we should consider 8e5ae84. It was triggered by nullability changes in Spring Security and has a similar end result but was only relevant to main. Getting things aligned across all three branches might save us a bit of merge pain in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth2ResourceServerJwtConfiguration.jwsAlgorithms(Set)and its reactive counterpart map each configured value throughSignatureAlgorithm.from(String)and add the result directly to the set.SignatureAlgorithm.fromreturnsnullfor unknown names, so a misconfiguration such asRS265(instead ofRS256) is silently accepted and only surfaces later as a confusing verification-time failure.Both methods now reject unknown algorithms with an
InvalidConfigurationPropertyValueException, matching the behaviour already used byexactlyOneAlgorithm()for the public-key path.Closes gh-50116