Apply path api version resolver last#50125
Open
barry3406 wants to merge 1 commit intospring-projects:mainfrom
Open
Apply path api version resolver last#50125barry3406 wants to merge 1 commit intospring-projects:mainfrom
barry3406 wants to merge 1 commit intospring-projects:mainfrom
Conversation
PathApiVersionResolver never returns null, so any resolvers registered after it in DefaultApiVersionStrategy are unreachable. Register the path-segment resolver last in configureApiVersioningUse so the header, query-parameter and media-type-parameter resolvers still run when path-segment is also configured. Closes spring-projectsgh-49800
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathApiVersionResolvernever returnsnull(as documented on the resolver itself), so any resolvers registered after it inDefaultApiVersionStrategyare unreachable. BecauseconfigureApiVersioningUsecurrently bindspath-segmentbeforemedia-type-parameter, configuring both causes the media-type (and any later bean-supplied) resolver to be skipped.This moves the
path-segmentbinding to the end ofconfigureApiVersioningUsein bothWebMvcAutoConfigurationandWebFluxAutoConfigurationso that the non-yielding path resolver is always consulted last. Tests are added that combinepath-segmentwithmedia-type-parameterand assert the media-type resolver still resolves.Closes gh-49800