PR: Fix showing signatures with type annotations in Help pane#25747
Open
jsbautista wants to merge 17 commits intospyder-ide:masterfrom
Open
PR: Fix showing signatures with type annotations in Help pane#25747jsbautista wants to merge 17 commits intospyder-ide:masterfrom
jsbautista wants to merge 17 commits intospyder-ide:masterfrom
Conversation
ccordoba12
reviewed
Apr 7, 2026
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Great work here @jsbautista! Just a few suggestions for you.
| documentation = doc.get('docstring', '') | ||
| note = doc.get('note', '') | ||
| is_function = '__main__' in note | ||
| if is_function and source_text: |
Member
There was a problem hiding this comment.
Suggested change
| if is_function and source_text: | |
| if is_function and source_text: |
For clarity.
| is_function = '__main__' in note | ||
| if is_function and source_text: | ||
| signature = unicodedata.normalize("NFKD", source_text) | ||
| match = re.search(r'def\s+.*?\)\s*(?:->\s*[^:]+)?\s*:', signature, re.S) |
Member
There was a problem hiding this comment.
Suggested change
| match = re.search(r'def\s+.*?\)\s*(?:->\s*[^:]+)?\s*:', signature, re.S) | |
| match = re.search( | |
| r'def\s+.*?\)\s*(?:->\s*[^:]+)?\s*:', signature, re.S | |
| ) |
Make line fit in 79 columns.
| signature = unicodedata.normalize("NFKD", source_text) | ||
| match = re.search(r'def\s+.*?\)\s*(?:->\s*[^:]+)?\s*:', signature, re.S) | ||
| args = '' | ||
| if match: |
Member
There was a problem hiding this comment.
Suggested change
| if match: | |
| if match: |
For clarity.
| 'argspec': args, | ||
| 'note': note, | ||
| 'docstring': documentation | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
Fix code style and add blank for clarity.
ccordoba12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix Verbose type annotations in help panel
Issue(s) Resolved
Fixes #22249
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista