fix: removed injected "export {}" from sqlite3-opfs-async-proxy.js #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d551b1cb30a02e291bc) (#19) Co-authored-by: jurerotar <28565137+jurerotar@users.noreply.github.com>
Contributor
Author
|
#143 should get merged before new release as well 😄 |
…e0990392a9380954992) (#20) Co-authored-by: jurerotar <28565137+jurerotar@users.noreply.github.com>
# Conflicts: # src/bin/sqlite3-bundler-friendly.mjs # src/bin/sqlite3-node.mjs # src/bin/sqlite3.mjs # src/bin/sqlite3.wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #141. The issue is that because
sqlite3-opfs-async-proxy.jsis marked as an entrypoint intsdownconfig, it's converted toesm. Since there's no esm-specific code there originally,rolldownadd aexport {}to the end, which breaks initializing this worker without{ type: 'module' }.@tomayac, I hate to bother you again, but we'll need another release. I'll add latest commits from sqlite as well.