Conversation
leonnicolas
approved these changes
Jul 16, 2021
This commit makes it possible to configure the MTU for the WireGuard interface created by Kilo. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat
commented
Jul 16, 2021
| local := flag.Bool("local", true, "Should Kilo manage routes within a location?") | ||
| logLevel := flag.String("log-level", logLevelInfo, fmt.Sprintf("Log level to use. Possible values: %s", availableLogLevels)) | ||
| master := flag.String("master", "", "The address of the Kubernetes API server (overrides any value in kubeconfig).") | ||
| mtu := flag.Uint("mtu", wireguard.DefaultMTU, "The MTU of the WireGuard interface created by Kilo.") |
Owner
Author
There was a problem hiding this comment.
e2e tests were failing because the Kilo container was crashlooping. This happened because I was passing "master" as the first argument, which caused flag to panic during flag-parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes it possible to configure the MTU for the WireGuard
interface created by Kilo.
Signed-off-by: Lucas Servén Marín lserven@gmail.com
Fixes: #208