Skip to content

pkg/mesh/routes.go: add flag for generic ACCEPT in FORWARD chain#244

Merged
leonnicolas merged 3 commits intomainfrom
forward_allow_option
Sep 30, 2021
Merged

pkg/mesh/routes.go: add flag for generic ACCEPT in FORWARD chain#244
leonnicolas merged 3 commits intomainfrom
forward_allow_option

Conversation

@leonnicolas
Copy link
Copy Markdown
Collaborator

Some linux distros or docker will set the default policy in the FORWARD
chain in the filter table to DROP. With the new ip-tables-forward-rules
flag a generic ACCEPT for all packages going from and to the pod subnet
is added to the FORWARD chain.

Fixes #241

Some linux distros or docker will set the default policy in the FORWARD
chain in the filter table to DROP. With the new ip-tables-forward-rules
flag a generic ACCEPT for all packages going from and to the pod subnet
is added to the FORWARD chain.

Signed-off-by: leonnicolas <leonloechner@gmx.de>
@squat
Copy link
Copy Markdown
Owner

squat commented Sep 30, 2021

xref: #112, #106,

Comment thread cmd/kg/main.go Outdated
Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
squat
squat previously approved these changes Sep 30, 2021
Copy link
Copy Markdown
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This implements exactly the same semantics as the identically named flag in Flannel (https://github.com/flannel-io/flannel/blob/master/main.go#L144).

Do you think we want a warning in the flag description?

@leonnicolas
Copy link
Copy Markdown
Collaborator Author

Looks good to me. This implements exactly the same semantics as the identically named flag in Flannel (https://github.com/flannel-io/flannel/blob/master/main.go#L144).

That was my plan, but I imagined an extra dash ^^

Do you think we want a warning in the flag description?

Something like: warning this may break firewalls with a deny all policy?

@squat
Copy link
Copy Markdown
Owner

squat commented Sep 30, 2021

Something like: warning this may break firewalls with a deny all policy?

Yes something like that would be great. Warning: this may break firewalls with a deny all policy and is potentially insecure

Comment thread cmd/kg/main.go Outdated
@leonnicolas leonnicolas requested a review from squat September 30, 2021 12:19
Copy link
Copy Markdown
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iptables FORWARD CHAIN POLICY

2 participants