prepend encapsulation rules to reduce number of reconciliation thereof#317
Merged
squat merged 1 commit intosquat:mainfrom Jul 14, 2022
Merged
Conversation
squat
previously approved these changes
Jun 29, 2022
Owner
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
As discussed in the Kilo Slack channel, I think this optimization makes a lot of sense and is a welcome addition 🎉
leonnicolas
previously approved these changes
Jun 29, 2022
Owner
|
I think we need to debug the e2e tests; something keeps causing then to time out during rollout of some deployment. |
Owner
|
(most likely unrelated to the PR) |
Collaborator
|
We need to investigate why the e2e tests fail. I don't think it is related to this PR. |
Collaborator
|
With #319 the e2e test should work again. Can you rebase the PR? |
because of the way the iptables rules are reconciled, having the encapsulation rules at the end of the slice of rules results in them being deleted and re-added many times, even though they are very static. Prepending them to the slice of rules prevents this from happening, making that iptables chain more stable and saving a bunch of roundtrips to iptables.
clive-jevons
force-pushed
the
prepend-encapsulation-rules-in-mesh
branch
from
7093aaa to
0f0b0bd
Compare
Contributor
Author
@leonnicolas <- done 😁 |
squat
approved these changes
Jul 14, 2022
Owner
|
thanks @clive-jevons! |
Contributor
Author
Always a pleasure - and thank you, @squat and @leonnicolas for all your support in getting this PR done 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because of the way the iptables rules are reconciled, having the encapsulation
rules at the end of the slice of rules results in them being deleted and re-added
many times, even though they are very static. Prepending them to the slice of
rules prevents this from happening, making that iptables chain more stable
and saving a bunch of roundtrips to iptables.