Make cleanup on shutdown optional#327
Merged
squat merged 3 commits intosquat:mainfrom Mar 28, 2023
dajudge:zero-downtime-restart
Merged
Make cleanup on shutdown optional#327squat merged 3 commits intosquat:mainfrom dajudge:zero-downtime-restart
squat merged 3 commits intosquat:mainfrom
dajudge:zero-downtime-restart
Conversation
Contributor
Author
|
rebased used it on a test cluster to update to a new build. went over without any networking hickups. |
Owner
|
thanks @dajudge! |
squat
approved these changes
Mar 28, 2023
Owner
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
nice, we can now use an already existing Kilo interface <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been looking into making kilo rollouts not resulting in a network-related downtime that's the result of cleanup on shutdown. From what I can tell almost all operations are already idempotent anyway.
The only issue i've been able to identify is the creation of the wireguard interface on startup - making that code path check for existence before trying to create a new one should prevent any issues there.
So far it's just an experiment, but I'd love to hear your thoughts on it!