Don't always write private key to disk#347
Merged
squat merged 1 commit intosquat:mainfrom Jan 31, 2023
Merged
Conversation
Only write private key to disk on new key generation. Otherwise just use what is there. This allows externally key generation and injection with a secret.
squat
approved these changes
Jan 31, 2023
Owner
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
Nice catch. Before, this should have "worked" because we would overwrite the existing key with the same value, however, this doesn't work with read-only filesystems and is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only write private key to disk on new key generation. Otherwise just use what is there. This allows externally key generation and injection with a secret.