This repository was archived by the owner on Sep 11, 2020. It is now read-only.
fix go vet issues, add go vet to CI#360
Merged
mcuadros merged 4 commits intosrc-d:masterfrom Apr 26, 2017
smola:go-vet
Merged
Conversation
smola
changed the title
Closed
mcuadros
suggested changes
Apr 26, 2017
|
|
||
| . "gopkg.in/check.v1" | ||
| "github.com/src-d/go-git-fixtures" | ||
| . "gopkg.in/check.v1" |
Contributor
There was a problem hiding this comment.
mix of internal and external imports
ajnavarro
suggested changes
Apr 26, 2017
plumbing/format/packfile/scanner.go
Outdated
| @@ -301,7 +301,7 @@ func (s *Scanner) copyObject(w io.Writer) (int64, error) { | |||
| } | |||
|
|
|||
| // Seek sets a new offset from start, returns the old position before the change | |||
Contributor
There was a problem hiding this comment.
You miss to change documentation
alcortesm
approved these changes
Apr 26, 2017
Contributor
alcortesm
left a comment
alcortesm
left a comment
There was a problem hiding this comment.
This change is a very welcome improvement, at last! thanks!
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=========================================
Coverage ? 76.67%
=========================================
Files ? 122
Lines ? 8458
Branches ? 0
=========================================
Hits ? 6485
Misses ? 1261
Partials ? 712
Continue to review full report at Codecov.
|
This has signature and behavior distinct from io.Seeker, go vet complains about this, so we change it to a different name to avoid confusion.
ajnavarro
approved these changes
Apr 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #349