This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: transport/http, Close http.Body reader when needed#657
Merged
mcuadros merged 1 commit intosrc-d:masterfrom Nov 24, 2017
ajnavarro:fix/close-http-response
Merged
plumbing: transport/http, Close http.Body reader when needed#657mcuadros merged 1 commit intosrc-d:masterfrom ajnavarro:fix/close-http-response
mcuadros merged 1 commit intosrc-d:masterfrom
ajnavarro:fix/close-http-response
Conversation
Contributor
Author
|
Related issue: src-d/borges#186 |
ajnavarro
changed the title
mcuadros
changed the title
If we don't do that, all the goroutines opened by the Body Reader are never closed, causing a 'fatal: morestack on g0' error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't do that, all the goroutines opened by the Body Reader are never closed, causing a 'fatal: morestack on g0' error.