Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Conversation

@vtexier
Copy link
Contributor

@vtexier vtexier commented Apr 24, 2020

  • Translate Liked correctly (Capitalized)
  • Add "new" translation

@black-puppydog
Copy link
Contributor

hey @vtexier apparently we managed to fix travis. can you rebase this?
by the way, this PR conflicts with #1273. I trust your language skills more than mine, but if you look at that PR, it also includes further strings missing from the French translation. In case you get bored at home. 😆

* Translate Liked correctly (Capitalized)
* Add "new" translation
@vtexier
Copy link
Contributor Author

vtexier commented Apr 25, 2020

Ok, I have removed the "Liked" (Capitalized) causing conflict, and removed the non used "liked" key.

I have left the missing "new" key, as if conflict it is simple to merge both.

@black-puppydog
Copy link
Contributor

ah, that was not what I meant. I was happy to expire my PR and just let you do your French. you're better at it than I am :D

@black-puppydog black-puppydog merged commit d33ad47 into ssbc:master Apr 25, 2020
@black-puppydog
Copy link
Contributor

one more question though: how did you determin that "liked" was unused?
I find one usage of it in lib/depject/message/html/render/vote.js:

return [i18n('liked'), ' ', api.message.html.link(link)]

but I find it super hard to trace the call paths in the code base.

I don't know what I'm doing meme

@vtexier
Copy link
Contributor Author

vtexier commented Apr 25, 2020

Ooops, I had no idea "liked" was used elsewhere. But in Patchwork, I got a Capitalized "Liked" not translated in french, and I see a "liked" not Capitalized in the json file so I thought, hey that the "L" that is a typo and the translator do not find the key.

But your finding prove me wrong... So let me know if you prefer i do all the french PR be myself.
I will cherry pick the other french PR and fix all I know...

@black-puppydog
Copy link
Contributor

Sure, go ahead, that way at least it will be true French. :)
Let me know if you're unclear about where & in which context the messages appear. Like I said, it's not always clear.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants