update and fix French locale. #1280
Conversation
|
@black-puppydog, work is done. Cherry picked your branch and fixed all the file! |
black-puppydog
left a comment
black-puppydog
left a comment
There was a problem hiding this comment.
Looks pretty nice, thank you for spending time on this! :)
There's two tiny changes I'd make (see the discussion above(?)).
I think we need to clean up the locales in general. I don't really like this system, it's unclear to me which strings are or are not used in the application, or how to find out.
But that's for another day. :)
| "followed": "followed", | ||
| "unfollowed": "unfollowed", | ||
| "followed": "suivi", | ||
| "unfollowed": "non suivi", |
There was a problem hiding this comment.
I think this is the verb "unfollow" but in past tense.
As in "J'ai arreté de suivre ..."
There was a problem hiding this comment.
It is the current state, not a past event. So "non suivi" is better imho.
locales/fr.json
Outdated
| "eo": "Esperanto", | ||
| "nl": "Néerlandais", | ||
| "zh-TW": "Taïwanais", | ||
| "Font Family": "Font Family", |
There was a problem hiding this comment.
Did you leave this one on purpose?
There was a problem hiding this comment.
Which one ? I just take what you did and complete the language. Font Family is useless but as I do not know if remove it can cause a side effect. I leave it as it is.
There was a problem hiding this comment.
"Font Family" is used in the settings screen:
There was a problem hiding this comment.
oops, sorry, I will translate it.
but there's a bunch of them still missing.
|
Thank you @vtexier! 🎉 |
2 participants
but there's a bunch of them still missing.