This repository was archived by the owner on May 12, 2021. It is now read-only.
Allow navigation to my own profile via search bar. #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the search bar included all the main views *except* the Profile. This was supposedly because for the other views the navigation is trivially done by a string constant, while navigating to the user's profile requires navigating to their feed ID. So this introduces the navigation to /profile as an alias to navigating to the user's own feed ID.
black-puppydog
force-pushed
the
searchbar-slash-profile
branch
from
ab77785 to
25a1b62
Compare
Powersource
approved these changes
May 11, 2020
Contributor
Powersource
left a comment
Powersource
left a comment
There was a problem hiding this comment.
Code looks sane enough, and I guess you've tested it works 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the search bar included all the main views except the Profile.
This was supposedly because for the other views the navigation is trivially
done by a string constant, while navigating to the user's profile requires
navigating to their feed ID.
So this introduces the navigation to /profile as an alias to navigating to
the user's own feed ID.