tui: add permission indicator to footer #4813
Conversation
|
I've been using this one all day and it is pretty awesome. One wish that you might not really be able to fulfill: it's nice if the indicator text has a dramatic, easily visible difference in colour from the regular text so it's easier to notice in a quick, distracted tenth of a second glance. Now, since the colours depend on the themes, there's only so much you could do: without knowing what theme someone is using, we can only take guesses as to which theme elements are more likely to have a visually distinct colouring, we couldn't really guarantee it easily... Great work though, I love it! |
terakael
force-pushed
the
feat/tui-permission-indicator
branch
from
6344719 to
e1f04b8
Compare
|
This is invaluable. I do hope it gets merged in soon. |
Add visible indicator in footer when permissions are pending to improve discoverability when user has scrolled away from the permission request. - Display permission count with warning color (◉ N Permission/Permissions) - Follows existing LSP/MCP pattern for accessing data via sync context - Uses terminal-safe Unicode character (◉ U+25C9 FISHEYE) - Warning color matches permission request border styling
terakael
force-pushed
the
feat/tui-permission-indicator
branch
from
d12691f to
5432963
Compare
|
I get so many prs now, you should @ me if i start missing somethign this is good but this is first time im seeing it |
|
lgtm |
|
/review |
|
lgtm |
3 participants
Add visible indicator in footer when permissions are pending to improve discoverability when user has scrolled away from the permission request.