feat: add role_assignment, user, sso_group resources and data sources #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMcKenzie
changed the title
ChrisMcKenzie
changed the title
ChrisMcKenzie
force-pushed
the
feature/RBAC-support-resources
branch
from
e807d72 to
7a1c00e
Compare
albertodonato
approved these changes
Jan 7, 2026
Contributor
albertodonato
left a comment
albertodonato
left a comment
There was a problem hiding this comment.
LGTM, thanks.
A couple of minor comments inline, but nothing really blocking
| func (r *roleAssignmentResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) { | ||
| // Role assignments must be imported using the composite key: "role_name,principal,target" | ||
| // Example: "viewer,user:1,account-group:abc-123" | ||
| parts := strings.Split(req.ID, ",") |
Contributor
There was a problem hiding this comment.
too bad we can't use importState here due to the : in ids...
fix: role_assignment bug where state was using id which does not work for querying objects from api.
ChrisMcKenzie
force-pushed
the
feature/RBAC-support-resources
branch
from
7a1c00e to
5d551fa
Compare
update: docs for user api and role_assignment
ChrisMcKenzie
force-pushed
the
feature/RBAC-support-resources
branch
from
5d551fa to
cd8529a
Compare
ChrisMcKenzie
changed the title
wgrant
reviewed
Jan 8, 2026
internal/models/user.go
Outdated
|
|
||
| roles, d := types.ListValueFrom(ctx, types.StringType, user.Roles) | ||
| diags.Append(d...) | ||
| m.Roles = roles |
There was a problem hiding this comment.
All four of these fields are deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5987
what
Adds
role_assignment,user,sso_groupresource types to terraform providerAdds
user,sso_groupdata sources to terraform provider.why
These data sources enable users to:
role_assignmentresourceThis is part of the RBAC support feature set, specifically focusing on resources and the data sources necessary to creating role assignments
testing
docs
examples/data-sources/stacklet_userandexamples/data-sources/stacklet_sso_group/as well as the resourcesexamples/resources/stacklet_role_assigment