This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Update config to add singleton instance and add inference unit tests#105
Merged
Update config to add singleton instance and add inference unit tests#105
Conversation
ptelang
force-pushed
the
add-inference-tests
branch
2 times, most recently
from
d22906c to
fcaba3b
Compare
jhrozek
reviewed
Nov 27, 2024
jhrozek
reviewed
Nov 27, 2024
jhrozek
reviewed
Nov 27, 2024
jhrozek
approved these changes
Nov 27, 2024
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
Looking good, I just left 2 questions inline, mostly for my education.
Member
aponcedeleonch
left a comment
aponcedeleonch
left a comment
There was a problem hiding this comment.
Not enough to stop the PR but we need to use the provider name in the URL:
@self.router.post(f"/{self.provider_route_name}/completion")
ptelang
force-pushed
the
add-inference-tests
branch
from
fcaba3b to
d3bae7c
Compare
ptelang
force-pushed
the
add-inference-tests
branch
from
d3bae7c to
458deb8
Compare
Contributor
Author
The provider name is added back in the URL. |
aponcedeleonch
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.