This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
This commit introduces Non-Functional Requirements: 1. Config Parser (supporting YAML config file and env vars_ 2. Logging framework (mutliple levels, text or json format, logging errors / warnings to stderr, and info, debug to stdout 3. CLI structure, basic flags, help, version command. Test coverage approx 80% Closes: #9
jhrozek
approved these changes
Nov 21, 2024
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
test work, starting the server works, review done interactively in a call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces Non-Functional Requirements:
Test coverage approx 80%
Closes: #9