This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Conversation
We still need to add unit tests for OpenAI, will add them in a separate patch.
lukehinds
approved these changes
Nov 25, 2024
lukehinds
left a comment
lukehinds
left a comment
There was a problem hiding this comment.
LGTM, I figure everything is completely mocked, no running server needed?
Contributor
Author
Yes, everything is mocked, it's really just unit tests, not e2e or integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still need to add unit tests for OpenAI, will add them in a separate
patch.