This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Conversation
lukehinds
reviewed
Nov 25, 2024
lukehinds
left a comment
lukehinds
left a comment
There was a problem hiding this comment.
code looks good, just a couple of observations I was not sure about
jhrozek
reviewed
Nov 25, 2024
jhrozek
reviewed
Nov 25, 2024
jhrozek
reviewed
Nov 25, 2024
jhrozek
reviewed
Nov 25, 2024
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
Just a couple of questions/comments, but overall looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.