Skip to content

Conversation

@jacinta-stacks
Copy link
Contributor

@jacinta-stacks jacinta-stacks commented Dec 5, 2025

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 36.33721% with 219 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.74%. Comparing base (6116402) to head (77c5f34).

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 9.52% 190 Missing ⚠️
libsigner/src/v0/messages.rs 86.23% 15 Missing ⚠️
stacks-node/src/tests/signer/mod.rs 31.25% 11 Missing ⚠️
stacks-signer/src/v0/signer_state.rs 66.66% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (68.74%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (6116402) and HEAD (77c5f34). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (6116402) HEAD (77c5f34)
69 66
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6742      +/-   ##
===========================================
- Coverage    77.52%   68.74%   -8.78%     
===========================================
  Files          582      582              
  Lines       361565   361820     +255     
===========================================
- Hits        280294   248739   -31555     
- Misses       81271   113081   +31810     
Files with missing lines Coverage Δ
stacks-signer/src/v0/signer_state.rs 71.76% <66.66%> (-2.37%) ⬇️
stacks-node/src/tests/signer/mod.rs 67.21% <31.25%> (-3.24%) ⬇️
libsigner/src/v0/messages.rs 73.04% <86.23%> (-12.79%) ⬇️
stacks-node/src/tests/signer/v0.rs 15.21% <9.52%> (-0.62%) ⬇️

... and 330 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6116402...77c5f34. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset looks good to me, but I think we can't merge global signer state machine activation to develop before we've concluded mainnet testing of the signer state machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants