feat(cli): fix duplicate binary name in stacks-signer version and fix typos #6778
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se typos - Related issue: stacks-network#5874 (Duplicate binary name in version output) - Related issue: stacks-network#5292 (Fix typos in the codebase) - Verified stacks-network#6558 is already resolved in main. Summary of changes: - Updated libsigner VERSION_STRING to not duplicate the binary name. - Corrected 'desierialized' -> 'deserialized' in libsigner. - Corrected 'contruct' -> 'construct' across stackslib, libsigner, and clarity-types.
Contributor
|
Hi @cryptoflops, thanks for your contribution! A couple of points to help move this forward smoothly:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the
stacks-signerCLI user experience and performs general codebase maintenance by addressing two separate "good first issues".Changes
versionforstacks-signer#5874): Updatedlibsignerto prevent the binary name from being printed twice when running--version.desierialized->deserialized,contruct->construct) acrosslibsigner,clarity-types, andstackslib.Related Issues
versionforstacks-signer#5874(Note: During implementation, I verified that #6558 is already correctly handled in the current master branch)