Deserializer for sum_to_zero matrix #3342

WardBrian · 2025-03-25T17:58:25Z

Submission Checklist

Run unit tests: ./runTests.py src/test/unit
Run cpplint: make cpplint
Declare copyright holder and open-source license: see below

Summary

De/serialization to accompany stan-dev/math#3169

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

bob-carpenter

This basically looks good---just a few doc corrections and a request for a boundary test.

One thing I've found is that for things like this, it can help to write a very simple test framework that tests the round tripping and tests gradients and log densities. Then you can use it to try out a bunch of examples.

src/stan/io/deserializer.hpp

src/test/unit/io/deserializer_test.cpp

src/test/unit/io/deserializer_stdvector_test.cpp

WardBrian · 2025-03-25T20:18:06Z

Thanks @bob-carpenter -- most of the doc comments you had also applied to the vector version (these were copied, primarily), so I've updated those as well.

We do have some test scaffolding for this in the deserializer_free_test.hpp, but it hasn't been extended to cover all the cases we test across these files. Would be worth doing at some point for sure.

bob-carpenter

Thanks for adding the boundary test.

bob-carpenter · 2025-03-25T20:22:48Z

This looks good. Feel free to merge when tests pass.

stan-buildbot · 2025-03-25T23:54:59Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.38	0.3	1.29	22.26% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.04	3.79% faster
gp_regr/gen_gp_data.stan	0.03	0.02	1.11	9.72% faster
gp_regr/gp_regr.stan	0.09	0.09	1.05	4.7% faster
sir/sir.stan	71.7	66.19	1.08	7.69% faster
irt_2pl/irt_2pl.stan	4.29	3.9	1.1	9.07% faster
eight_schools/eight_schools.stan	0.06	0.05	1.09	8.55% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.26	0.24	1.07	6.91% faster
pkpd/one_comp_mm_elim_abs.stan	20.27	18.46	1.1	8.93% faster
garch/garch.stan	0.41	0.4	1.03	2.5% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.61	2.58	1.01	1.34% faster
arK/arK.stan	1.79	1.72	1.04	4.07% faster
gp_pois_regr/gp_pois_regr.stan	2.77	2.69	1.03	2.85% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.76	8.31	1.05	5.17% faster
performance.compilation	184.3	180.67	1.02	1.97% faster
Mean result: 1.0744710735387761

Jenkins Console Log
Blue Ocean
Commit hash: 4adb4ac5420f16dca008d1b8a4c39b44dd6fea4d

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

src/stan/io/deserializer.hpp

stan-buildbot · 2025-03-27T16:33:32Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.32	0.3	1.06	6.01% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.01	0.55% faster
gp_regr/gen_gp_data.stan	0.03	0.02	1.05	5.16% faster
gp_regr/gp_regr.stan	0.09	0.09	1.06	5.72% faster
sir/sir.stan	68.91	67.16	1.03	2.55% faster
irt_2pl/irt_2pl.stan	4.18	3.99	1.05	4.47% faster
eight_schools/eight_schools.stan	0.06	0.05	1.04	4.3% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.26	0.24	1.06	5.51% faster
pkpd/one_comp_mm_elim_abs.stan	20.6	18.42	1.12	10.59% faster
garch/garch.stan	0.46	0.41	1.12	10.63% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.85	2.62	1.09	7.99% faster
arK/arK.stan	1.95	1.74	1.12	10.79% faster
gp_pois_regr/gp_pois_regr.stan	2.93	2.71	1.08	7.54% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	9.02	8.41	1.07	6.69% faster
performance.compilation	189.88	181.12	1.05	4.61% faster
Mean result: 1.0671724440745107

Jenkins Console Log
Blue Ocean
Commit hash: 4adb4ac5420f16dca008d1b8a4c39b44dd6fea4d

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 1081.123
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

stan-buildbot · 2025-03-27T23:01:07Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.33	0.3	1.07	6.84% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.08	7.07% faster
gp_regr/gen_gp_data.stan	0.03	0.02	1.11	9.72% faster
gp_regr/gp_regr.stan	0.09	0.09	1.05	5.06% faster
sir/sir.stan	69.41	66.94	1.04	3.56% faster
irt_2pl/irt_2pl.stan	4.12	3.99	1.03	3.09% faster
eight_schools/eight_schools.stan	0.06	0.05	1.06	5.94% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.26	0.24	1.06	5.4% faster
pkpd/one_comp_mm_elim_abs.stan	19.96	18.72	1.07	6.24% faster
garch/garch.stan	0.44	0.41	1.09	7.93% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.65	2.71	0.98	-2.52% slower
arK/arK.stan	1.83	1.75	1.05	4.65% faster
gp_pois_regr/gp_pois_regr.stan	2.87	2.79	1.03	2.91% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.89	8.53	1.04	3.99% faster
performance.compilation	184.15	182.1	1.01	1.11% faster
Mean result: 1.0506018343835004

Jenkins Console Log
Blue Ocean
Commit hash: 4adb4ac5420f16dca008d1b8a4c39b44dd6fea4d

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

stan-buildbot · 2025-03-28T16:13:38Z

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
arma/arma.stan	0.32	0.31	1.06	5.51% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	1.07	6.94% faster
gp_regr/gen_gp_data.stan	0.02	0.02	1.04	4.2% faster
gp_regr/gp_regr.stan	0.09	0.09	1.05	5.1% faster
sir/sir.stan	70.49	66.16	1.07	6.13% faster
irt_2pl/irt_2pl.stan	4.15	3.91	1.06	5.63% faster
eight_schools/eight_schools.stan	0.06	0.05	1.04	4.17% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.26	0.25	1.04	4.28% faster
pkpd/one_comp_mm_elim_abs.stan	20.13	18.5	1.09	8.11% faster
garch/garch.stan	0.44	0.4	1.1	9.34% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.77	2.61	1.06	5.94% faster
arK/arK.stan	1.86	1.71	1.09	8.18% faster
gp_pois_regr/gp_pois_regr.stan	2.88	2.7	1.07	6.28% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.86	8.32	1.07	6.12% faster
performance.compilation	181.3	180.77	1.0	0.29% faster
Mean result: 1.0614836204512803

Jenkins Console Log
Blue Ocean
Commit hash: 3d0d6c996961fb2dba4e1e71aceeaf0a35d746c7

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

WardBrian added 2 commits March 25, 2025 13:54

Deserializer for sum_to_zero matrix

2f570c7

Update serializer test

4fb65a8

WardBrian mentioned this pull request Mar 25, 2025

Add sum_to_zero_matrix type stan-dev/stanc3#1506

Merged

2 tasks

bob-carpenter requested changes Mar 25, 2025

View reviewed changes

Doc and test updates per review

408fbc3

bob-carpenter approved these changes Mar 25, 2025

View reviewed changes

spinkney reviewed Mar 26, 2025

View reviewed changes

src/stan/io/deserializer.hpp Outdated Show resolved Hide resolved

spinkney reviewed Mar 26, 2025

View reviewed changes

src/stan/io/deserializer.hpp Outdated Show resolved Hide resolved

Repair comment typo

a310800

Merge branch 'develop' into serde/sum-to-zero-matrix

616aa0e

WardBrian merged commit 6ec4b0b into develop Mar 28, 2025
3 checks passed

WardBrian deleted the serde/sum-to-zero-matrix branch March 28, 2025 16:31

Uh oh!

Deserializer for sum_to_zero matrix #3342

Deserializer for sum_to_zero matrix #3342

Uh oh!

Conversation

WardBrian commented Mar 25, 2025

Submission Checklist

Summary

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Uh oh!

bob-carpenter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WardBrian commented Mar 25, 2025

Uh oh!

bob-carpenter left a comment

Choose a reason for hiding this comment

Uh oh!

bob-carpenter commented Mar 25, 2025

Uh oh!

stan-buildbot commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

stan-buildbot commented Mar 27, 2025

Uh oh!

stan-buildbot commented Mar 27, 2025

Uh oh!

stan-buildbot commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants