Add stochastic row and column matrix types #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
requested changes
Jul 26, 2024
Member
WardBrian
left a comment
WardBrian
left a comment
There was a problem hiding this comment.
Mostly looks good, a few scattered questions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
- Coverage 89.56% 89.52% -0.05%
==========================================
Files 63 63
Lines 10593 10614 +21
==========================================
+ Hits 9488 9502 +14
- Misses 1105 1112 +7
|
WardBrian
reviewed
Jul 29, 2024
Member
WardBrian
left a comment
WardBrian
left a comment
There was a problem hiding this comment.
One testing comment and one optional item but otherwise this looks good to me
Member
|
On further reflection, I think the reason we use "simplex" and "corr_matrix" is that's how someone would say them in conversation. Nobody says "simplex vector" but everyone says "correlation matrix". We weren't consistent with "ordered", which someone would say as "ordered vector". |
WardBrian
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
Adds row and column stochastic matrix types
See the example here for more
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)