This repository was archived by the owner on Jan 20, 2022. It is now read-only.
feat(Text): introduced important prop to the Text component#120
Merged
feat(Text): introduced important prop to the Text component#120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=========================================
- Coverage 69.94% 69.8% -0.15%
=========================================
Files 74 75 +1
Lines 1198 1202 +4
Branches 227 206 -21
=========================================
+ Hits 838 839 +1
- Misses 355 358 +3
Partials 5 5
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text
Added important prop for the text.
TODO
API Proposal
Important
The important prop is used for styling the text to appear as more important and draw's user attention. Added a importantWeight variable to the Text component for customizing the fontWeight when using the important prop.