This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(MenuItem): Item separator - replace ::before with box-shadow#1105
Merged
miroslavstastny merged 4 commits intomasterfrom Mar 26, 2019
Merged
fix(MenuItem): Item separator - replace ::before with box-shadow#1105miroslavstastny merged 4 commits intomasterfrom
miroslavstastny merged 4 commits intomasterfrom
Conversation
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
+ Coverage 82.11% 82.14% +0.03%
==========================================
Files 716 716
Lines 8559 8554 -5
Branches 1165 1165
==========================================
- Hits 7028 7027 -1
+ Misses 1515 1511 -4
Partials 16 16
Continue to review full report at Codecov.
|
Member
Author
|
This does not fix pointing menu which uses |
mnajdova
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
:beforewithbox-shadowto draw vertical line between menu items in Teams theme.This is necessary to fix OSX/Chrome/VoiceOver screen reader navigation between menu items.
Fixes #982.