Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(List): fix propTypes warning in ListItem#1266

Merged
layershifter merged 3 commits intomasterfrom
fix/list-warning
Apr 25, 2019
Merged

fix(List): fix propTypes warning in ListItem#1266
layershifter merged 3 commits intomasterfrom
fix/list-warning

Conversation

@layershifter
Copy link
Member

Picked from #1224.

Fixes this warning:

Warning: Failed prop type: Invalid prop `column` of type `object` supplied to `Flex`, expected `boolean`.
    in Flex (created by ListItem)
    in ListItem (created by List)
    in ul (created by List)
    in List (created by ListExampleSelectable)

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1266 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1266   +/-   ##
======================================
  Coverage    72.1%   72.1%           
======================================
  Files         731     731           
  Lines        5592    5592           
  Branches     1612    1612           
======================================
  Hits         4032    4032           
  Misses       1555    1555           
  Partials        5       5
Impacted Files Coverage Δ
packages/react/src/components/List/ListItem.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49e121...65c1015. Read the comment docs.

@layershifter layershifter merged commit 4c5d373 into master Apr 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/list-warning branch April 25, 2019 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants